[PATCH] D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases

Sat Apr 25 02:37:17 PDT 2020

anchu-rajendran added a comment.

In D78424#2002860 <https://reviews.llvm.org/D78424#2002860>, @klausler wrote:

> https://reviews.llvm.org/D78834 contains the patch that reworks check-data.{h,cpp} to check typed expressions rather than the raw parse tree.  Please adjust this change to do the same, if possible.

Thank You!  I went through your patch and now, I get your point on why we should implement semantic checks on typed expressions. **I have tried to implement C876 and C877 on  top of this patch and I could perform those checks on typed expressions.** I will submit those for review after you merge your patch.

The change to convert code to have checks on typed expressions was asked by you on my previous patch (https://reviews.llvm.org/D78008). I asked for a merge as I was not sure about the changes you were expecting and I thought the code in this patch would be least affected.  Sorry for my misunderstanding and thanks for the changes!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78424/new/

https://reviews.llvm.org/D78424