[PATCH] D78796: [Support] Refactor LEB128 encoding into an input iterator

Nicolas Guillemot via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 24 21:05:52 PDT 2020


nlguillemot marked an inline comment as done.
nlguillemot added inline comments.


================
Comment at: llvm/include/llvm/Support/LEB128.h:90
+  ///
+  /// \param PadTo ZExt the output to this number of bytes if fewer than this
+  /// number of bytes have been outputted.
----------------
Self-review: This comment is wrong, it's not always ZExt. Whether the padding is ZExt or SExt depends on IsSigned.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78796/new/

https://reviews.llvm.org/D78796





More information about the llvm-commits mailing list