[PATCH] D77143: [llvm-dwp] Refuse DWARFv5 input DWP files.

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good - thanks!



================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:657
+        return make_error<DWPError>(
+            std::string("unsupported tu_index version: ") +
+            utostr(TUIndex.getVersion()) +
----------------
I think if you make this first thing a StringRef or Twine, rather than a std::string, you should be able to concatenate the rest without needing to wrap the last literal in a std::string, eg:

```
StringRef("foo")  + utostr(x) + "bar"
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77143/new/

https://reviews.llvm.org/D77143