[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/include/llvm/ADT/SmallVector.h:84
 
+template <class Size_T> const size_t SmallVectorBase<Size_T>::SizeTypeMax;
+
----------------
nikic wrote:
> Is this needed? I don't think it makes a lot of sense to allow odr-use of `SizeTypeMax`. As it's a protected member, it's only used in the SmallVector implementation, where we control how it is used.
It's used as a parameter to std::min, so it's already odr used & I'd rather not leave it as a trap to walk around even if we addressed that issue.

I assume if it were a constexpr local in a protected inline function it wouldn't hinder optimizations in any real way?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77621/new/

https://reviews.llvm.org/D77621