[PATCH] D78736: [DWARF5]: Added support for dumping strx forms in llvm-dwarfdump

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX updated this revision to Diff 259936.
SouraVX added a comment.

Addressed @ikudrin comments thanks for this!

- replaced `normal_units()` with `compile_units()`
- Skipped the units which doesn't contribute to macro section.
- Removed `getStringOffsetsExtractor` from arguments and used the corresponding `getStringOffsetSectionItem()` function to retrieve strings.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78736/new/

https://reviews.llvm.org/D78736

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
  llvm/test/DebugInfo/X86/debug-macro-multi-cu-strx.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78736.259936.patch
Type: text/x-patch
Size: 12044 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200424/84ac1dc4/attachment.bin>