[PATCH] D78790: [mlir][DialectConversion] Add support for properly tracking replaceUsesOfBlockArgument

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey accepted this revision.
GMNGeoffrey added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: mlir/lib/Transforms/DialectConversion.cpp:200
   /// operations as necessary.
-  // FIXME(riverriddle) The 'mapping' parameter is only necessary because the
-  // implementation of replaceUsesOfBlockArgument is buggy.
----------------
Does this mean the mapping parameter is no longer necessary? Seems like there's still something to fix if it shouldn't be necessary


================
Comment at: mlir/test/lib/Dialect/Test/TestPatterns.cpp:251
+    auto illegalOp =
+        rewriter.create<ILLegalOpF>(op->getLoc(), rewriter.getF32Type());
+    rewriter.replaceUsesOfBlockArgument(op->getRegion(0).front().getArgument(0),
----------------
Not this revision, but WTF is with the capitalization on ILLegal?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78790/new/

https://reviews.llvm.org/D78790