[PATCH] D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases

Peter Klausler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 24 09:09:37 PDT 2020


klausler added a comment.

In D78424#2001397 <https://reviews.llvm.org/D78424#2001397>, @kiranchandramohan wrote:

> If all the concerns are addressed, you can merge. Thanks for working on this.


Earlier, Anchu said that she would change this code to use typed expressions.  Has this been done?  It doesn't look like it.  It took me most of the week to rework her earlier patch to use the right representation.  None of these analyses should be done on the parse tree, and the new functions in parser/tools.h aren't necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78424/new/

https://reviews.llvm.org/D78424





More information about the llvm-commits mailing list