[PATCH] D78761: [Flang][CMake] Add explicit libFortranCommon dependency for f18 etc.

[David Truby via Phabricator via llvm-commits]

DavidTruby accepted this revision.
DavidTruby added a comment.
This revision is now accepted and ready to land.

I think we should make the libraries have transitive dependencies so that you can choose to link only against the one that you think you're using. For example, linking against any of the other libraries should link against FortranCommon anyway I believe? 
This should be doable with CMake's target properties, perhaps the add_flang_library should do this.

The change itself looks fine though, if it fixes builds for you I think you can merge it while we look at doing what I suggest above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78761/new/

https://reviews.llvm.org/D78761