[PATCH] D78705: [mlir][linalg] Use memory effect to detecting allocation

[Lei Zhang via Phabricator via llvm-commits]

antiagainst marked 2 inline comments as done.
antiagainst added inline comments.


================
Comment at: mlir/include/mlir/Dialect/StandardOps/IR/Ops.td:279
 
-def AllocOp : AllocLikeOp<"alloc"> {
+def AllocOp : AllocLikeOp<"alloc", [MemoryEffects<[MemAlloc]>]> {
   let summary = "memory allocation operation";
----------------
mehdi_amini wrote:
> rriddle wrote:
> > Can we add to AllocLikeOp instead? Ideally marking the returned value directly.
> Should this be rebased on top of https://reviews.llvm.org/D78619 ?
Oh, thanks for the pointer! I'll wait that CL to land and then rebase. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78705/new/

https://reviews.llvm.org/D78705