[PATCH] D78781: [mlir][DictionaryAttr] Add a new getWithSorted and use it when possible

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar accepted this revision.
jpienaar added a comment.
This revision is now accepted and ready to land.

Thanks, this will fit the bill well :-)



================
Comment at: mlir/include/mlir/IR/Attributes.h:279
 
+  /// Construct a dictionary attribute with the provided set of named
+  /// attributes.
----------------
Set confuses me here, is it meant to convey unordered? (an alternative is just to say array or vector as by default there is no assumption that it would be sorted specially IMHO)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78781/new/

https://reviews.llvm.org/D78781