[PATCH] D78636: [CodeGen] Use SPLAT_VECTOR for zeroinitialiser with scalable types

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:1579
+        SmallVector<SDValue, 16> Ops;
+
+        Ops.assign(cast<FixedVectorType>(VecTy)->getNumElements(), Op);
----------------
nit: unnecessary newline.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:1583
+      }
+    } else
+      llvm_unreachable("Unknown vector constant");
----------------
nit: the else is not necessary here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78636/new/

https://reviews.llvm.org/D78636