[PATCH] D78422: [LLD][ELF][ARM] Fix ARM Exidx order for non monotonic section order

Fri Apr 24 03:45:04 PDT 2020

psmith added a comment.

In D78422#1999427 <https://reviews.llvm.org/D78422#1999427>, @psmith wrote:

> I had to revert due to an msan build bot failure. I don't fully understand it yet http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/40693/steps/check-lld%20msan/logs/stdio as I can't yet see how script->assignAddresses would not set OutSec->addr. However msan is more likely to be right than me.

OK, found it. It wasn't that OutSec->addr hadn't been set, it was that the .ARM.exidx SyntheticSection size was unitialized (it is set by finalize()) and this polluted the addr values calculated by assignAddresses, an update to initialize the size based on an estimate of .ARM.exidx section size pre-compression fixes the problem. Will recommit with fix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78422/new/

https://reviews.llvm.org/D78422