[PATCH] D76115: Add debug support for set types

Fri Apr 24 01:02:16 PDT 2020

djtodoro added a comment.

In D76115#2001144 <https://reviews.llvm.org/D76115#2001144>, @demoitem wrote:

> I'm new to this, my first contribution, so bear with me.
>
> On my local branch I had 2 commits
>  and I used the following to get a patch (following the docs)
>
> git show HEAD -U999999 > set.patch

The `HEAD` refers to the `SHA` of the specific commit.

> The second patch I uploaded seemed to only have the changes from the second commit - which I thought was okay.
> 
> Can you advise? Is each patch supposed to contain the complete set of commits for the changed code and get a new Differential number?

Yes. If the patches are logically different it makes sense to make separate changes here. If the diffs are connected (they represent the same functionality/feature/intention), it makes sense to make a stack of the patches (Edit Related Revision -> Edit Parent/Child rev).

So, if your local repo looks as:

  commit 878787...
  Author: ...
  Date:   ...

      [LLVM] ..

  commit 989898...
  Author: ...
  Date:   ...

      [Clang] ..

you can create the patches for the Phabricator as:

  git show 989898... -U999999 > name_of_the_change1.patch
  git show 878787... -U999999 > name_of_the_change2.patch

> I am slightly confused.
> 
> Also, regards the Verifier changes, I have only tested them locally but I guess I should produce a test file. So I will get started on that.
> 
> Thanks

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76115/new/

https://reviews.llvm.org/D76115