[PATCH] D78773: Adjust libMLIR building to more closely follow libClang

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer added inline comments.


================
Comment at: mlir/cmake/modules/AddMLIR.cmake:90
+  if(TARGET ${name})
+    target_link_libraries(${name} INTERFACE ${LLVM_COMMON_LIBS})
+
----------------
I think dependency problem is solved if you change INTERFACE to PUBLIC here.


================
Comment at: mlir/tools/mlir-shlib/CMakeLists.txt:35
+  add_llvm_library(
+    MLIR
     SHARED
----------------
I think MLIR almost universally puts this on the previous line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78773/new/

https://reviews.llvm.org/D78773