[PATCH] D78764: [RISCV] Update debug scratch register names

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 23 17:25:11 PDT 2020


jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVSystemOperands.td:358
+// drafts of the RISC-V debug spec
+let AltName = "dscratch" in {
+def : SysReg<"dscratch0", 0x7B2>;
----------------
I think
```
def : SysReg<"dscratch0", 0x7B2> {
  let AltName = "dscratch";
}
```
is nicer, but otherwise please drop the braces, ie:
```
let AltName = "dscratch" in
def : SysReg<"dscratch0", 0x7B2>
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78764/new/

https://reviews.llvm.org/D78764





More information about the llvm-commits mailing list