[PATCH] D77187: [lld][WebAssembly] Add initial support for -Map/--print-map

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/wasm/OutputSections.cpp:234
     section->outputSec = this;
+    section->outputOffset = payloadSize;
     payloadSize += section->getSize();
----------------
MaskRay wrote:
> This order shuffle is not needed.
This is to make it match the above two for loops where `section->outputSec = this;` is the first line.


================
Comment at: lld/wasm/OutputSegment.h:41
   uint32_t startVA = 0;
+  OutputSection *outputSec = nullptr;
   std::vector<InputSegment *> inputSegments;
----------------
MaskRay wrote:
> Add a comment what this means. It seems that `outputSec` is purely for debugging purposes (`-M`).
On further inspection I was able to revert this part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77187/new/

https://reviews.llvm.org/D77187