[PATCH] D78341: Change callbr to only define its output SSA variable on the normal path, not the indirect targets.

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 23 15:47:45 PDT 2020


jyknight added a comment.

In D78341#1989923 <https://reviews.llvm.org/D78341#1989923>, @efriedma wrote:

> There's one part of this that's a little subtle: if an indirect destination is the same as the normal destination, the value is available at that destination even if the indirect edge is taken.
>
> That's not necessarily a problem at the IR level, but we might need to special-case it in isel.


That's not actually possible: it results in an error "Duplicate callbr destination!".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78341/new/

https://reviews.llvm.org/D78341





More information about the llvm-commits mailing list