[PATCH] D78434: [mlir] resolve types from attributes in assemblyFormat

Martin Waitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 23 15:15:16 PDT 2020


tali marked 3 inline comments as done.
tali added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/OpFormatGen.cpp:1742
+    variableTyResolver[rhsName] = {
+        lhsArg, nullptr, def.getValueAsString("transformer")};
+  else if (const auto *attr = findSeenAttr(lhsName))
----------------
rriddle wrote:
> Is there a reason why we couldn't use the transformer with the attribute type?
Haven't found a need to do so, but added it in next revision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78434/new/

https://reviews.llvm.org/D78434





More information about the llvm-commits mailing list