[PATCH] D78663: [builtins] Add 32-bit shift builtins

[Ayke via Phabricator via llvm-commits]

aykevl marked an inline comment as done.
aykevl added inline comments.


================
Comment at: compiler-rt/test/builtins/Unit/ashlsi3_test.c:3
+// REQUIRES: librt_has_ashlsi3
+//===-- ashlsi3_test.c - Test __ashlsi3 -----------------------------------===//
+//
----------------
MaskRay wrote:
> Test files don't need file headers. There are plenty of examples in `clang/test/`
All the other compiler-rt builtins tests (compiler-rt/test/builtins/Unit/*_test.c) do have a header. Should I deviate from that convention for new files?

One difference between these tests and the Clang tests is that these tests are in some sense full programs (with `main`) while Clang tests are usually just small incomplete source files, just testing whether the correct IR is generated.

(This file is a modified version of ashldi3_test.c, hence the style it follows).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78663/new/

https://reviews.llvm.org/D78663