[PATCH] D78608: [llvm] [CodeGen] Fixed vector halving bug for masked load

Thu Apr 23 11:53:45 PDT 2020

aartbik added inline comments.

================
Comment at: llvm/test/CodeGen/X86/pr45563-2.ll:1
+; RUN: llc < %s -O3 -mattr=avx | FileCheck %s
+
----------------
craig.topper wrote:
> aartbik wrote:
> > dmgreen wrote:
> > > Please use update_llc_test_checks on tests this size
> > Ah, I saw some auto generated messages, but was not aware of this tool. But, forgive my noobness, what will this auto-generate? I am really just counting the number of masked moves that result, I don't want to pin down the full assembly?
> It will generate checks for the full assembly, but the X86 maintainers are used to that. We'll just rerun the script and look at the diff if it fails for some change in the future.
Nice utility! Having the full assembly makes it a bit sensitive to changes, but I can also see that the X86 maintainers want to be aware of even the slightest of changes and with this utility that becomes a lot simpler. Cool!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78608/new/

https://reviews.llvm.org/D78608