[PATCH] D78555: [DebugInfo][DWARF64] Fix dumping pre-standard .debug_str_offsets.dwo sections.

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added a comment.

LGTM, with a slight caveat regarding reporting an error for degenerate stubs of string offset sections.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:247
-}
-
 // Dump the .debug_addr section.
----------------
Nice to get rid of this code!


================
Comment at: llvm/test/DebugInfo/X86/dwarfdump-str-offsets-invalid-5.s:13
+# INVALIDSECTIONLENGTH: .debug_str_offsets contents:
+# INVALIDSECTIONLENGTH: 0x00000000: Gap, length = 1
----------------
This isn't particularly important but it would be nice to emit a more precise error message on a degenerate .debug_str_offsets section like this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78555/new/

https://reviews.llvm.org/D78555