[PATCH] D78647: [MLIR] Lower GenericAtomicRMWOp to llvm.cmpxchg.

Thu Apr 23 02:06:26 PDT 2020

pifon2a marked an inline comment as done.
pifon2a added inline comments.
Herald added a reviewer: ftynse.

================
Comment at: mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp:2796
+    auto *loopBlock = rewriter.splitBlock(initBlock, initPosition);
+    auto loopArgument = loopBlock->addArgument(valueType);
+    auto loopPosition = rewriter.getInsertionPoint();
----------------
ftynse wrote:
> This is not allowed in conversion patterns (it is not undoable). I've recently introduced a functionality to create block in a rewriter-compatible way, `rewriter.createBlock(initBlock->getParent(), std::next(Region::iterator(initBlock)), valueType);` should work.
Thanks a lot, Alex. Good to know that it is not allowed. I ll send a patch to fix this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78647/new/

https://reviews.llvm.org/D78647