[PATCH] D78627: [obj2yaml] - Zero initialize program headers. NFCI.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with one suggestion.



================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:764
     if (YamlPhdr.Offset) {
-      if (!Fragments.empty() && *YamlPhdr.Offset > PhdrFileOffset)
+      if (!Fragments.empty() && *YamlPhdr.Offset > Fragments.front().Offset)
         reportError("'Offset' for segment with index " + Twine(PhdrIdx) +
----------------
Maybe worth pulling `Fragments.front().Offset` into a variable so that you don't have to repeat its call three times?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78627/new/

https://reviews.llvm.org/D78627