[PATCH] D78608: [llvm] [CodeGen] Fixed vector halving bug for masked load

[Aart Bik via Phabricator via llvm-commits]

aartbik marked 3 inline comments as done.
aartbik added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1596
+    // remove the unused element in the chain.
+    Hi = Lo;
+  } else {
----------------
dmgreen wrote:
> Could we return PassThruHi directly?
I experimented with different values, this seemed the least code change, since it folds directly in the DAG.getNode below, and is removed right after that. Any thing else would require more changes to deal with the 1 vs 2 result values.


================
Comment at: llvm/test/CodeGen/X86/pr45563-2.ll:1
+; RUN: llc < %s -O3 -mattr=avx | FileCheck %s
+
----------------
dmgreen wrote:
> Please use update_llc_test_checks on tests this size
Ah, I saw some auto generated messages, but was not aware of this tool. But, forgive my noobness, what will this auto-generate? I am really just counting the number of masked moves that result, I don't want to pin down the full assembly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78608/new/

https://reviews.llvm.org/D78608