[PATCH] D78665: [TLI] Optimize no-builtins attribute check (NFC)

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 23:18:41 PDT 2020


wenlei accepted this revision.
wenlei added a comment.

Thanks for fix. On the other hand, if `hasFnAttribute` is so expensive to the point that we need to refrain from using it, that's probably an indication that we should try to speed up `hasFnAttribute`.

> because attributes are stored as a plain list (not a map)

And sounds like there's opportunity for a nice speed up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78665/new/

https://reviews.llvm.org/D78665





More information about the llvm-commits mailing list