[PATCH] D78688: [ValueTracking] Handle shufflevector constants in ComputeNumSignBits

[Huihui Zhang via Phabricator via llvm-commits]

huihuiz accepted this revision.
huihuiz added a comment.
This revision is now accepted and ready to land.

Looks fine with me.



================
Comment at: llvm/test/Transforms/InstCombine/nsw.ll:138
+;
+  %xx = zext <vscale x 2 x i8> %z to <vscale x 2 x i64>
+  %shuf = shufflevector <vscale x 2 x i64> insertelement (<vscale x 2 x i64> undef, i64 1, i32 0), <vscale x 2 x i64> zeroinitializer, <vscale x 2 x i32> zeroinitializer
----------------
Not needed, just shuffle(insertelement) + mul will get this crash.
But not very important.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78688/new/

https://reviews.llvm.org/D78688