[PATCH] D78010: [CodeGen] Add new function unionImplicitOps() to union implicit register

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 20:38:33 PDT 2020


lkail added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineInstr.cpp:1442
+
+    assert(!MO.isRegMask() && "Don't support union for RegMask operand");
+  }
----------------
Shall we just put this assertion after where `MO` is defined?


================
Comment at: llvm/lib/CodeGen/MachineInstr.cpp:1451
+
+    assert(!MO.isRegMask() && "Don't support union for RegMask operand");
+  }
----------------
Same as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78010/new/

https://reviews.llvm.org/D78010





More information about the llvm-commits mailing list