[PATCH] D78355: [LLParser] Delete temporary CallInst when error occurs in ParseCall

Qiu Chaofan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 20:06:38 PDT 2020


qiucf added a comment.

In D78355#1989054 <https://reviews.llvm.org/D78355#1989054>, @spatel wrote:

> Should we fix the definition of FPMathOperator and/or change the IR verifier instead? How did that call acquire FMF in the first place?


It's not correct IR. However, that's a crash we'd like to avoid.

I was not clear we can't add FMF to functions returning int. We can only add `enable-unsafe-fp-math` to use native instruction instead of libcall (at least, on PPC), but the option is deprecated. That seems to be an issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78355/new/

https://reviews.llvm.org/D78355





More information about the llvm-commits mailing list