[PATCH] D78689: Isolate zero_whitespace parser test into its own file.

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 20:06:37 PDT 2020


silvas created this revision.
silvas added a reviewer: rriddle.
Herald added subscribers: llvm-commits, Kayjukh, frgossen, grosul1, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, jpienaar, mehdi_amini.
Herald added a project: LLVM.
rriddle accepted this revision.
This revision is now accepted and ready to land.
silvas added a comment.

zero_whitespace.mlir looks like this:

  // RUN: mlir-opt %s | FileCheck %s
  
  // This test is in a different file because it contains a literal NUL
  // character, which causes various tools to treat it as a binary file.
  // Hence it is useful to have this test kept in a separate, rarely-changing
  // file.
  
  // CHECK-LABEL: func @zero_whitespace() {
  // CHECK-NEXT: return
  func @zero_whitespace() {
    ^@  // This is a \0 byte.
    return
  }


This test is in a different file because it contains a literal NUL
character, which causes various tools to treat it as a binary file.
Hence it is useful to have this test kept in a separate, rarely-changing
file.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78689

Files:
  mlir/test/IR/parser.mlir
  mlir/test/IR/zero_whitespace.mlir




-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78689.259459.patch
Type: text/x-patch
Size: 0 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200423/b848f1d2/attachment-0001.bin>


More information about the llvm-commits mailing list