[lld] 673612a - [LLD][ELF][ARM] Replace adr, ldr with .inst .reloc in test [NFC]

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 04:57:37 PDT 2020


Author: Peter Smith
Date: 2020-04-22T12:55:26+01:00
New Revision: 673612a0358b6ec953749d7c57ff33da73954e11

URL: https://github.com/llvm/llvm-project/commit/673612a0358b6ec953749d7c57ff33da73954e11
DIFF: https://github.com/llvm/llvm-project/commit/673612a0358b6ec953749d7c57ff33da73954e11.diff

LOG: [LLD][ELF][ARM] Replace adr, ldr with .inst .reloc in test [NFC]

After D78301 MC no longer emits a relocation for this case. Change to use
.inst and .reloc to synthesize the same instruction and relocation. One
more test case I missed.

Added: 
    

Modified: 
    lld/test/ELF/arm-thumb-pc8-weak.s

Removed: 
    


################################################################################
diff  --git a/lld/test/ELF/arm-thumb-pc8-weak.s b/lld/test/ELF/arm-thumb-pc8-weak.s
index e0fe2442347e..e42f48963179 100644
--- a/lld/test/ELF/arm-thumb-pc8-weak.s
+++ b/lld/test/ELF/arm-thumb-pc8-weak.s
@@ -1,7 +1,7 @@
 // REQUIRES: arm
-// RUN: llvm-mc --arm-add-build-attributes -filetype=obj -triple=thumbv6a-none-linux-gnueabi %s -o %t
+// RUN: llvm-mc --arm-add-build-attributes -filetype=obj -triple=thumbv5-none-linux-gnueabi %s -o %t
 // RUN: ld.lld %t -o %t2
-// RUN: llvm-objdump --no-show-raw-insn --triple=thumbv6a-none-linux-gnueabi -d %t2
+// RUN: llvm-objdump --no-show-raw-insn --triple=thumbv6a-none-linux-gnueabi -d %t2 | FileCheck %s
 
 /// Check that the ARM ABI rules for undefined weak symbols are applied.
 /// Relative relocations are resolved to the place. Although we can't encode
@@ -16,9 +16,12 @@
  .global _start
 _start:
  /// R_ARM_THM_PC8
- adr r0, target
- ldr r0, target
-
-// CHECK: 000110b4 _start:
-// CHECK-NEXT: 110b4: adr     r0, #0
+ /// adr r0, target
+ .inst.n 0xa0ff
+ .reloc 0, R_ARM_THM_PC8, target
+ /// ldr r0, target
+ .inst.n 0x48ff
+ .reloc 2, R_ARM_THM_PC8, target
+// CHECK:      000200b4 <_start>:
+// CHECK-NEXT: 200b4: adr     r0, #0
 // CHECK-NEXT:        ldr     r0, [pc, #0]


        


More information about the llvm-commits mailing list