[PATCH] D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases

[Anchu Rajendran S via Phabricator via llvm-commits]

anchu-rajendran added a comment.

In D78424#1993281 <https://reviews.llvm.org/D78424#1993281>, @kiranchandramohan wrote:

> Thanks for addressing the comments.
>
> Also check the following.
>
>   type t1
>    integer, allocatable :: arr(:)
>   end type
>   type(t1) d1
>   data d1/t1((/0,1/))/
>   
>
> Besides the constraints for the data statement, there are several other points mentioned in the data statement section. Like point 8 in 8.6.7 (test below) which says that the number of variables and data-statement-constants shall be the same. Are these outside the scope of your work? If so, please create a ticket somewhere so that we can come back to it later.
>
>   program mn
>     character(len=3) :: n1, n2
>     data n1, n2 / 'f18' /
>   end
>


I see that there are a few more constraints listed as you mentioned which requires expression evaluations and type checking. I will create a ticket for them now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78424/new/

https://reviews.llvm.org/D78424