[PATCH] D78592: [mlir][SCCP] Add support for propagating across symbol based calls

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 02:08:18 PDT 2020


rriddle marked an inline comment as done.
rriddle added a comment.

In D78592#1996224 <https://reviews.llvm.org/D78592#1996224>, @bondhugula wrote:

> Looks great!
>
> > It assumes that the arguments of callable can be tracked so long as we know that all of the uses are calls.
>
> When can the arguments not be tracked? And shouldn't the CallableOpInterface guarantee that?


I thought I had a reason originally, but after thinking about it the constraints of symbol visibility already guarantee this today.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78592/new/

https://reviews.llvm.org/D78592





More information about the llvm-commits mailing list