[PATCH] D78615: [ValueTracking] Let propagatesPoison support binops/unaryops/cast/etc.

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 01:36:01 PDT 2020


aqjune created this revision.
aqjune added reviewers: spatel, lebedev.ri, jdoerfert, reames, nikic, sanjoy.
aqjune added a project: LLVM.
Herald added a subscriber: javed.absar.
aqjune added a parent revision: D78503: RFC: [ValueTracking] Let analyses assume a value cannot be partially poison.

This patch makes propagatesPoison be more accurate by returning true on
more bin ops/unary ops/casts/etc.

The changed test in ScalarEvolution/nsw.ll was introduced by
https://github.com/llvm/llvm-project/commit/a19edc4d15b0dae0210b90615775edd76f021008 .
IIUC, the goal of the tests is to show that iv.inc's SCEV expression still has
no-overflow flags even if the loop isn't in the wanted form.
It becomes more accurate with this patch, so think this is okay.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78615

Files:
  llvm/include/llvm/Analysis/ValueTracking.h
  llvm/lib/Analysis/ValueTracking.cpp
  llvm/lib/Transforms/Instrumentation/PoisonChecking.cpp
  llvm/test/Analysis/ScalarEvolution/nsw.ll
  llvm/unittests/Analysis/ValueTrackingTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78615.259197.patch
Type: text/x-patch
Size: 8275 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200422/ab188f37/attachment.bin>


More information about the llvm-commits mailing list