[PATCH] D77893: [lld] Merge Mach-O input sections

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 20:33:18 PDT 2020


int3 added inline comments.


================
Comment at: lld/MachO/OutputSegment.h:49
+  OutputSection *getOrCreateOutputSection(StringRef name);
+  void setOutputSection(OutputSection *os);
 
----------------
int3 wrote:
> `addOutputSection` seems like a more fitting name
also, I think if would make sense if we moved `createOutputSection` from Writer.cpp to a method on this class, then this helper method can be made private


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77893/new/

https://reviews.llvm.org/D77893





More information about the llvm-commits mailing list