[PATCH] D78551: [MLIR] Use nested symbol to identify kernel in `LaunchFuncOp`.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 11:20:59 PDT 2020


rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/IR/SymbolTable.h:12
 
+#include "mlir/IR/Attributes.h"
 #include "mlir/IR/OpDefinition.h"
----------------
The include is unnecessary.


================
Comment at: mlir/lib/Dialect/GPU/IR/GPUDialect.cpp:17
 #include "mlir/Dialect/StandardOps/IR/Ops.h"
+#include "mlir/IR/Attributes.h"
 #include "mlir/IR/Builders.h"
----------------
This is unnecessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78551/new/

https://reviews.llvm.org/D78551





More information about the llvm-commits mailing list