[PATCH] D78174: [VE] Add alternative names to registers

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 10:48:16 PDT 2020


arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/VE/MCTargetDesc/VEInstPrinter.cpp:41
+  unsigned AltIdx = VE::AsmName;
+  OS << '%' << StringRef(getRegisterName(RegNo, AltIdx)).lower();
 }
----------------
kaz7 wrote:
> arsenm wrote:
> > You should be able to directly use the output of getRegisterName without the lower now?
> That's true.  I haven't noticed it.  Thank you for very useful comments to reduce computation time.  I really appreciate it.
You don't need to construct a stringref either


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78174/new/

https://reviews.llvm.org/D78174





More information about the llvm-commits mailing list