[PATCH] D78348: [AMDGPU] Add missing AReg classes

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 10:48:08 PDT 2020


rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:1107
   case AMDGPU::VReg_96RegClassID:
+  case AMDGPU::AReg_96RegClassID:
     return 96;
----------------
foad wrote:
> rampitec wrote:
> > Missing AGPR* classes.
> True, but it is also missing most VGPR* classes and some SGPR* classes. Are they really all supposed to be included here?
I think they are. If these will appear in MI operand definitions eventually it will assert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78348/new/

https://reviews.llvm.org/D78348





More information about the llvm-commits mailing list