[PATCH] D78541: [MLIR] Ensure `gpu.func` must be inside a `gpu.module`.

Mahesh Ravishankar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 09:10:16 PDT 2020


mravishankar requested changes to this revision.
mravishankar added a comment.
This revision now requires changes to proceed.

@ftynse , @herhut is this giving any added semantic advantage? I have been trying to see if there is a way to target `gpu.func` directly without going through `gpu.launch` + outlining. Having the requirement that a `gpu.func` always live in a `gpu.module` seems too restrictive. Just want to understand the advantage apart from the fact that all `gpu.func` need to live in a module "separate" from the host side.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78541/new/

https://reviews.llvm.org/D78541





More information about the llvm-commits mailing list