[PATCH] D78500: [DWARF5]:Added support for .debug_macro.dwo section in llvm-dwarfdump

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX updated this revision to Diff 259009.
SouraVX added a comment.
Herald added a reviewer: jdoerfert.

Addressed @dblaikie comments, thanks for this!
This revision extends llvm-dwarfdump to support `*define_strx/*undef_strx` forms dumping present in either `macro` or `macro.dwo` section.
As it is evident from here `strx` form support is a bit expensive from parsing/dumping point of view. In case of non-split macro we have to search in all CUs for `DW_AT_str_offsets_base`, in order to dump info correctly.

- Added test case containing multiple CU's contribution to `debug_macro` section represented using `strx` forms. llvm-dwarfdump is able to parse and dump macro info correctly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78500/new/

https://reviews.llvm.org/D78500

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFObject.h
  llvm/include/llvm/MC/MCObjectFileInfo.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
  llvm/lib/MC/MCObjectFileInfo.cpp
  llvm/test/DebugInfo/X86/debug-macro-dwo.s
  llvm/test/DebugInfo/X86/debug-macro-multi-cu-strx.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78500.259009.patch
Type: text/x-patch
Size: 23112 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200421/1a6c6e23/attachment.bin>