[PATCH] D78549: Improve disassembly of branch targets in non-relocatable objects

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 08:04:16 PDT 2020


Higuoxing added a comment.

LGTM with one minor suggestion :)



================
Comment at: llvm/test/tools/llvm-objdump/X86/disassemble-same-section-addr.test:27
+## Print no target if no symbol in section/absolute symbol found.
+# RUN: yaml2obj %s --docnum=1 -o %t5 -D SIZE1=1 -D SIZE2=0 -D SECTION=.caller -D INDEX=SHN_LOPROC
+# RUN: llvm-objdump -d %t6 | FileCheck %s --check-prefix=FAIL
----------------
```
# RUN: yaml2obj ... -o %5 ...
#                      ^ Should be '%6', right?
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78549/new/

https://reviews.llvm.org/D78549





More information about the llvm-commits mailing list