[PATCH] D78544: FixIrreducible: don't crash when moving a child loop

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/Transforms/FixIrreducible/bug45623.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -fix-irreducible -S | FileCheck %s -check-prefix=CHECK
+
----------------
Don't need to specify the default check prefix


================
Comment at: llvm/test/Transforms/FixIrreducible/bug45623.ll:4-6
+; ModuleID = 'bugpoint-reduced-simplified.bc'
+source_filename = "./system/lib/libc/musl/src/regex/regexec.c"
+target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
----------------
Can remove these


================
Comment at: llvm/test/Transforms/FixIrreducible/bug45623.ll:7
+target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
+target triple = "wasm32-unknown-emscripten"
+
----------------
Does the triple matter? If so it belongs in a wasm test directory?


================
Comment at: llvm/test/Transforms/FixIrreducible/bug45623.ll:96
+
+attributes #0 = { "use-soft-float"="false" }
----------------
Is this really needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78544/new/

https://reviews.llvm.org/D78544