[PATCH] D78558: [Support] Make DataExtractor error messages more clear

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 06:59:11 PDT 2020


labath marked an inline comment as done.
labath added inline comments.


================
Comment at: llvm/include/llvm/Support/DataExtractor.h:696
+  /// error object to indicate an error.
+  bool prepareRead(uint64_t Offset, uint64_t Size, Error *E) const;
+
----------------
jhenderson wrote:
> Any particular reason this is `protected`, not `private`?
There is, though it's fairly arbitrary -- it seemed like it could be useful to subclasses like DWARFDataExtractor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78558/new/

https://reviews.llvm.org/D78558





More information about the llvm-commits mailing list