[PATCH] D78559: [MLIR] Verify there are no side-effecting ops in GenericAtomicRMWOp body.

[Alex Zinenko via Phabricator via llvm-commits]

ftynse added inline comments.


================
Comment at: mlir/lib/Dialect/StandardOps/IR/Ops.cpp:515
+      if (MemoryEffectOpInterface::hasNoEffect(&nestedOp) &&
+          nestedOp.getNumRegions() == 0)
+        continue;
----------------
This looks like it also disallows ops with regions inside the atomic region. While I don't see an immediate use-case for it, I also don't think we should just ban them. Maybe `walk` the op instead and check for side effects?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78559/new/

https://reviews.llvm.org/D78559