[PATCH] D78389: [ELF] Keep local symbols when both --emit-relocs and --discard-all are specified

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: lld/test/ELF/emit-relocs-discard-locals.s:9
+# RUN: llvm-readobj -r %tlocal | FileCheck --check-prefix=REL %s
+# RUN: ld.lld --emit-relocs --discard-locals --gc-sections %t.o -o %tlocal.gc
+# RUN: llvm-nm %tlocal.gc | FileCheck --check-prefix=NM %s
----------------
grimar wrote:
> Why it is important to test `--gc-sections`/`--no-gc-sections` too?
This comment was forgotten it seems. Please add a comment, I guess the reason to test "-gc-sections" is "just in case"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78389/new/

https://reviews.llvm.org/D78389