[PATCH] D63614: [System Model] [TTI] Update cache and prefetch TTI interfaces

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 18:28:15 PDT 2020


ychen added inline comments.


================
Comment at: llvm/trunk/include/llvm/CodeGen/BasicTTIImpl.h:509
 
+  virtual Optional<unsigned>
+  getCacheSize(TargetTransformInfo::CacheLevel Level) const {
----------------
BasicTTIImplBase is a CRTP base. The virtual here seems odd. Why not just move the SystemZ & Hexagon implementation to be under the MCSubtarget hierarchy and get rid of the virtual here? 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63614/new/

https://reviews.llvm.org/D63614





More information about the llvm-commits mailing list