[PATCH] D78243: New pass to make internal linkage symbol names unique

Sriraman Tallam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 15:46:02 PDT 2020


tmsriram added a comment.

In D78243#1993284 <https://reviews.llvm.org/D78243#1993284>, @echristo wrote:

> In D78243#1990101 <https://reviews.llvm.org/D78243#1990101>, @tmsriram wrote:
>
> > In D78243#1990057 <https://reviews.llvm.org/D78243#1990057>, @MaskRay wrote:
> >
> > > You may need an `opt -passes='...'` test for the new pass manager and implement the new pass.
> > >
> > > We are using `-fexperimental-new-pass-manager` heavily.
> >
> >
> > I am already testing -fexperimental-new-pass-manager in D73307 <https://reviews.llvm.org/D73307>, need to do it here?
>
>
> Probably wouldn't hurt to have both an explicit test for each pass manager.


I saw this after I pushed.  I can follow it up with a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78243/new/

https://reviews.llvm.org/D78243





More information about the llvm-commits mailing list