[PATCH] D78519: Update mlir for CreateShuffleVector with unsigned deprecation

Jacques Pienaar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 15:46:01 PDT 2020


jpienaar accepted this revision.
jpienaar added a comment.
This revision is now accepted and ready to land.

Looks good modulo variable names (e.g., postion and mask) and feel free to use [{ ... ]} form instead and or move it inside and have

let llvmBuilder = [{

as LLVM_ExtractValueOp does. If Alex has different suggestion then this can be followed up on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78519/new/

https://reviews.llvm.org/D78519





More information about the llvm-commits mailing list