[PATCH] D68408: [InstCombine] Negator - sink sinkable negations

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 15:12:42 PDT 2020


xbolva00 added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp:2005
+  return Cleanup();
 }
 
----------------
lebedev.ri wrote:
> xbolva00 wrote:
> > Just wondering if we could use some better name for this lambda than “cleanup”.
> I couldn't come up with a better one, any suggestions?
> `TryToNarrowDeduceFlags()`?
> This is where `goto` might make sense, but somehow i don't want to use it..
Your idea is fine I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68408/new/

https://reviews.llvm.org/D68408





More information about the llvm-commits mailing list