[PATCH] D78234: [BranchFolding] assert when removing INLINEASM_BR indirect targets

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 14:38:36 PDT 2020


nickdesaulniers added a comment.

In D78234#1989777 <https://reviews.llvm.org/D78234#1989777>, @efriedma wrote:

> > That sounds like you really really want MachineBasicBlocks as MachineOperands for INLINEASM_BR, as opposed to BlockAddresses?
>
> Yes. :)


Ok, do note that `BlockAddress`es are used from IR down through `AsmPrinter`, so targeting replacing them first in `INLINEASM_BR` I think means that we'll have to recreate the `BlockAddress`es at some point.  Once they're gone in MIR, we can remove them from `callbr` in LLVM IR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78234/new/

https://reviews.llvm.org/D78234





More information about the llvm-commits mailing list