[PATCH] D78417: [SlotIndexes] Add insertion point for insertMBBIntoMaps

[Marcello Maggioni via Phabricator via llvm-commits]

kariddi added a comment.

I don't get completely what is the difference between this and just calling insertMBBInMaps() with the new block created by split as the argument. Shouldn't the insertion point being automatically devised correctly if the block is inserted in the right position?



================
Comment at: llvm/include/llvm/CodeGen/SlotIndexes.h:609
+    /// before the given machine instr, otherwise it will be placed
+    /// immediately following the block's predecessor.
+    void insertMBBInMaps(MachineBasicBlock *mbb,
----------------
It seems it is actually put "before the next block in MachineFunction insertion order" (I don't think it has anything to do with it being a predecessor or a successor).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78417/new/

https://reviews.llvm.org/D78417